Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-1273) Allowlist Ruby symbols in YAML validator #624

Merged
merged 2 commits into from
Feb 11, 2019

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Feb 11, 2019

Ruby symbols are the only additional classes allowed in Puppet's YAML loader, so this should be the only one we need to add.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 92.894% when pulling cc5fd97 on rodjek:pdk-1273 into 553e6e0 on puppetlabs:master.

Copy link
Contributor

@scotje scotje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rodjek rodjek merged commit 0ca65ed into puppetlabs:master Feb 11, 2019
@rodjek rodjek deleted the pdk-1273 branch February 11, 2019 21:43
@bmjen bmjen added the bug label Feb 27, 2019
@david22swan
Copy link
Member

Changing the PR name in so that it doesn't contain any offensive terminology that is then added to the changelog.
Apologies for any offense.

@david22swan david22swan changed the title (PDK-1273) Whitelist Ruby symbols in YAML validator (PDK-1273) Allowlist Ruby symbols in YAML validator Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants